[
https://issues.apache.org/jira/browse/STORM-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15409216#comment-15409216
]
ASF GitHub Bot commented on STORM-2023:
---------------------------------------
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1610
STORM-2023 Add calcite-core to dependency of storm-sql-runtime
* also copy (transitive) dependencies to binary distribute, as
storm-sql-core did
It can be easily applied to 1.x-branch.
We can apply this to 1.0.x-branch but without STORM-2016 users still need
to copy them to extlib directory which is bad.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-2023
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1610.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1610
----
commit 34d9bf2d87667669d45c5166f8827f23369124ca
Author: Jungtaek Lim <[email protected]>
Date: 2016-08-05T09:16:13Z
STORM-2023 Add calcite-core to dependency of storm-sql-runtime
* also copy (transitive) dependencies to binary distribute, as
storm-sql-core did
----
> Add calcite-core to dependency of storm-sql-runtime
> ---------------------------------------------------
>
> Key: STORM-2023
> URL: https://issues.apache.org/jira/browse/STORM-2023
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-sql
> Affects Versions: 1.0.0
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
>
> storm-sql provides both "storm-sql-core" and "storm-sql-runtime". Former is
> for compiling sql to trident topology, and latter is for running compiled
> trident topology.
> While testing storm-sql feature I found compiled class codes refers calcite
> so calcite-core is needed at runtime.
> I'm not sure we can make calcite-core get out of storm-sql-runtime, so for
> now we can add calcite-core to storm-sql-runtime so that it can be available
> on transitive dependencies for storm-sql-runtime.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
