Github user satishd commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1608#discussion_r74005045
  
    --- Diff: storm-core/src/jvm/org/apache/storm/StormSubmitter.java ---
    @@ -233,6 +236,23 @@ public static void submitTopologyAs(String name, Map 
stormConf, StormTopology to
                     if(topologyNameExists(conf, name, asUser)) {
                         throw new RuntimeException("Topology with name `" + 
name + "` already exists on cluster");
                     }
    +
    +                // Dependency uploading only makes sense for distributed 
mode
    +                List<String> jarsBlobKeys;
    +                List<String> artifactsBlobKeys;
    +
    +                DependencyUploader uploader = new DependencyUploader();
    +                try {
    +                    uploader.init();
    +                    jarsBlobKeys = 
uploadDependencyJarsToBlobStore(uploader);
    +                    artifactsBlobKeys = 
uploadDependencyArtifactsToBlobStore(uploader);
    --- End diff --
    
    Both `jarsBlobKeys` and `artifactsBlobKeys` should be removed from blob 
store when topology submission is failed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to