Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/1608#discussion_r74029648 --- Diff: storm-core/src/jvm/org/apache/storm/StormSubmitter.java --- @@ -238,39 +239,24 @@ public static void submitTopologyAs(String name, Map stormConf, StormTopology to } // Dependency uploading only makes sense for distributed mode - List<String> jarsBlobKeys; + List<String> jarsBlobKeys = Collections.emptyList(); List<String> artifactsBlobKeys; DependencyUploader uploader = new DependencyUploader(); try { uploader.init(); jarsBlobKeys = uploadDependencyJarsToBlobStore(uploader); artifactsBlobKeys = uploadDependencyArtifactsToBlobStore(uploader); + setDependencyBlobsToTopology(topology, jarsBlobKeys, artifactsBlobKeys); + submitTopologyInDistributeMode(name, topology, opts, progressListener, asUser, conf, serConf); + } catch (Throwable e) { + // remove uploaded jars blobs, not artifacts since they're shared across the cluster + uploader.deleteBlobs(jarsBlobKeys); --- End diff -- @HeartSaVioR Is not there a possibility that the topology is submitted successfully on nimbus but client receives thrift error because of some timeout or connection error? My preference is to remove those topologies only when we know definitely that the topology submission is failed.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---