[
https://issues.apache.org/jira/browse/STORM-2032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15416534#comment-15416534
]
ASF GitHub Bot commented on STORM-2032:
---------------------------------------
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1618#discussion_r74367640
--- Diff:
storm-core/src/jvm/org/apache/storm/messaging/netty/StormClientHandler.java ---
@@ -60,7 +60,6 @@ public void messageReceived(ChannelHandlerContext ctx,
MessageEvent event) {
//This should be the metrics, and there should only be one
of them
List<TaskMessage> list = (List<TaskMessage>)message;
if (list.size() < 1) throw new RuntimeException("Didn't
see enough load metrics ("+client.getDstAddress()+") "+list);
- if (list.size() != 1) LOG.warn("Messages are not being
delivered fast enough, got "+list.size()+" metrics messages at
once("+client.getDstAddress()+")");
--- End diff --
I'm also OK for this approach. If we pick this, comment doesn't need to be
modified.
> "not fast enough" metrics WARN message in netty client can be misinterpreted
> ----------------------------------------------------------------------------
>
> Key: STORM-2032
> URL: https://issues.apache.org/jira/browse/STORM-2032
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Affects Versions: 2.0.0
> Reporter: Derek Dagit
> Assignee: Derek Dagit
> Priority: Minor
>
> Example:
> bq. WARN Messages are not being delivered fast enough, got 3 metrics messages
> at once
> It appears to some users to be a good signal for monitoring/alerting, but
> really this is not part of the design.
> We should remove it, change it, or lower the log level.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
