[ 
https://issues.apache.org/jira/browse/STORM-2016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15418867#comment-15418867
 ] 

ASF GitHub Bot commented on STORM-2016:
---------------------------------------

GitHub user HeartSaVioR opened a pull request:

    https://github.com/apache/storm/pull/1626

    STORM-2016 Topology submission improvement: support adding local jars and 
maven artifacts on submission

    PR for 1.x is here: #1608 
    
    storm-submit is copied version of 1.x, but I have to reimplement (port to 
Java) some part of storm-core. So please have a look thoughtfully when 
reviewing files on storm-core.
    
    I also fixed a bug from outside of pull request regarding symbolic link.
    
    @harshach @satishd 
    Please review this when you have some time. Thanks!

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HeartSaVioR/storm STORM-2016

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1626.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1626
    
----
commit 97615a4b5e9c3567ffd5b0642b60fc8e55e713ef
Author: Jungtaek Lim <kabh...@gmail.com>
Date:   2016-08-12T13:58:08Z

    STORM-2016 Topology submission improvement: support adding local jars and 
maven artifacts on submission
    
    *NOTE* This contains a bugfix at creating symbolic link
    
    * bin/storm now supports "--jars" and "--artifacts" options
    ** it's only effective with "storm jar" and "storm sql"
    * introduce new module: storm-submit to help resolving dependencies with 
handling transitive dependencies
    * StormSubmitter will upload dependencies to BlobStore when submitting 
topology
    ** StormSubmitter will remove jars blobs when topology submission fails
    *** remove jar blobs when only one of AlreadyAliveException, 
InvalidTopologyException, AuthorizationException occurs
    * Supervisor will download dependencies from BlobStore when such topology 
is assigned
    * Supervisor will launch workers with adding downloaded dependencies to 
worker classpath
    * Nimbus will remove jars from BlobStore when topology is killed
    ** don't remove artifacts from blobstore since it's shared across topologies
    * add options to document (Command-line-client.md) and also storm.py
    ** it will be printed out when 'help jar' and 'help sql' is called

----


> Topology submission improvement: support adding local jars and maven 
> artifacts on submission
> --------------------------------------------------------------------------------------------
>
>                 Key: STORM-2016
>                 URL: https://issues.apache.org/jira/browse/STORM-2016
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-core
>            Reporter: Jungtaek Lim
>            Assignee: Jungtaek Lim
>
> This JIRA tracks actual work on below proposal / design document.
> https://cwiki.apache.org/confluence/display/STORM/A.+Design+doc%3A+adding+jars+and+maven+artifacts+at+submission
> Proposal discussion thread is here: 
> http://mail-archives.apache.org/mod_mbox/storm-dev/201608.mbox/%3ccaf5108i9+tjanz0lgrktmkvqel7f+53k9uyzxct6zhsu6oh...@mail.gmail.com%3E
> Let's post on discussion thread if we have any opinions / ideas on this 
> instead of leaving comments on this issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to