[ 
https://issues.apache.org/jira/browse/STORM-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15423183#comment-15423183
 ] 

ASF GitHub Bot commented on STORM-2039:
---------------------------------------

Github user knusbaum commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1627#discussion_r74990425
  
    --- Diff: storm-core/src/clj/org/apache/storm/daemon/worker.clj ---
    @@ -316,7 +316,6 @@
           :load-mapping (LoadMapping.)
           :assignment-versions assignment-versions
           :backpressure (atom false) ;; whether this worker is going slow
    -      :transfer-backpressure (atom false) ;; if the transfer queue is 
backed-up
           :backpressure-trigger (atom false) ;; a trigger for synchronization 
with executors
    --- End diff --
    
    Let's just make this an Object. The fact that it's an atom is misleading.


> Backpressure refactoring in worker and executor
> -----------------------------------------------
>
>                 Key: STORM-2039
>                 URL: https://issues.apache.org/jira/browse/STORM-2039
>             Project: Apache Storm
>          Issue Type: Story
>            Reporter: Alessandro Bellina
>            Assignee: Alessandro Bellina
>            Priority: Minor
>
> * Use backpressure flags directly from disruptor queue instead of in the 
> disruptor-backpressure-handlers in worker and executor
> * Other minor refactoring (eliminate redundant function)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to