Github user zhuoliu commented on the issue:
https://github.com/apache/storm/pull/1627
@abellina looks good to me, just one extra suggestion:
In
https://github.com/apache/storm/blob/master/storm-core/src/clj/org/apache/storm/daemon/worker.clj#L156
To reduce the traffic to ZK, we checked the previous flag to update to
Zookeeper only when it is necessary (the flag has changed), but still there may
some weird case we have inconsistency between local "prev-backpressure-flag"
and the worker backpressure node at Zookeeper (see STORM-1949).
So to strike a tradeoff and avoid the possible wrong stall of a topology,
could you add do a random number generation here, e.g., generate a number
between 0-9, if it is zero, we will call the try block no matter
"prev-backpressure-flag" and "curr-backpressure-flag" is equal or not.
Thanks a lot!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
