Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/1595
  
    Struggled with this but no luck. This is not that easy as just checking the 
interface type.
    
    1. Entire logic is strongly tied to IMetricsConsumer and 
IMetricConsumer.DataPoint. Given that we would want to introduce 
IAggregatedMetricsConsumer and IAggregatedMetricsConsumer.DataPoint (or 
AggregatedDataPoint), we need to fix all of the usages including Filter and 
MetricsConsumerBolt and so on. We can't fix IMetricsConsumer and its DataPoint 
as non-backward compatible way.
    
    2. Aggregating metrics should be handled from SystemBolt, not 
MetricsConsumerBolt which we initialize the metrics consumer. We're allowing 
users to set multiple metrics consumers for the topology, which means that user 
can set both IMetricsConsumer and IAggregatedMetricsConsumer. Do we want to 
push the metrics to both unaggregated and aggregated things via separate stream?
    
    Please share the idea with details if anyone has better and clean one. 
Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to