Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77411245
--- Diff: storm-core/src/jvm/org/apache/storm/utils/ConfigUtils.java ---
@@ -353,25 +350,21 @@ public LocalState nimbusTopoHistoryStateImpl(Map
conf) throws IOException {
}
// we use this "weird" wrapper pattern temporarily for mocking in
clojure test
- public static Map readSupervisorStormConf(Map conf, String stormId)
throws IOException {
+ public static Map<String, Object> readSupervisorStormConf(Map<String,
Object> conf, String stormId) throws IOException {
return _instance.readSupervisorStormConfImpl(conf, stormId);
}
- public Map readSupervisorStormConfImpl(Map conf, String stormId)
throws IOException {
+ public Map<String, Object> readSupervisorStormConfImpl(Map<String,
Object> conf, String stormId) throws IOException {
String stormRoot = supervisorStormDistRoot(conf, stormId);
String confPath = supervisorStormConfPath(stormRoot);
return readSupervisorStormConfGivenPath(conf, confPath);
}
// we use this "weird" wrapper pattern temporarily for mocking in
clojure test
- public static StormTopology readSupervisorTopology(Map conf, String
stormId) throws IOException {
- return _instance.readSupervisorTopologyImpl(conf, stormId);
- }
-
- public StormTopology readSupervisorTopologyImpl(Map conf, String
stormId) throws IOException {
+ public static StormTopology readSupervisorTopology(Map conf, String
stormId, AdvancedFSOps ops) throws IOException {
--- End diff --
I put in the AdvancedFSOps to handle the mocking, but now I am not so sure
on that. It is too low level for a lot of what we want to do, so I think I
will put it back in, and just do the mocking at the higher level.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
