Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1682#discussion_r78509264
--- Diff:
external/sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/ISqlTridentDataSource.java
---
@@ -17,14 +17,32 @@
*/
package org.apache.storm.sql.runtime;
-import org.apache.storm.trident.operation.Function;
-import org.apache.storm.trident.spout.IBatchSpout;
import org.apache.storm.trident.spout.ITridentDataSource;
+import org.apache.storm.trident.state.StateFactory;
+import org.apache.storm.trident.state.StateUpdater;
/**
* A ISqlTridentDataSource specifies how an external data source produces
and consumes data.
*/
public interface ISqlTridentDataSource {
+ class SqlTridentConsumer {
+ private StateFactory stateFactory;
+ private StateUpdater stateUpdater;
+
+ public SqlTridentConsumer(StateFactory stateFactory, StateUpdater
stateUpdater) {
+ this.stateFactory = stateFactory;
+ this.stateUpdater = stateUpdater;
+ }
+
+ public StateFactory getStateFactory() {
+ return stateFactory;
+ }
+
+ public StateUpdater getStateUpdater() {
+ return stateUpdater;
+ }
+ }
+
ITridentDataSource getProducer();
--- End diff --
how about add some javadoc for interface methods in `ISqlTridentDataSource`
and `DataSource`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
