Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r78965321
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/RunAsUserContainer.java
---
@@ -0,0 +1,94 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.daemon.supervisor;
+
+import java.io.File;
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Map;
+
+import org.apache.storm.container.ResourceIsolationInterface;
+import org.apache.storm.generated.LocalAssignment;
+import org.apache.storm.utils.LocalState;
+import org.apache.storm.utils.Utils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class RunAsUserContainer extends BasicContainer {
+ private static final Logger LOG =
LoggerFactory.getLogger(RunAsUserContainer.class);
+
+ public RunAsUserContainer(ContainerType type, Map<String, Object>
conf, String supervisorId, int port,
+ LocalAssignment assignment, ResourceIsolationInterface
resourceIsolationManager, LocalState localState,
+ String workerId, Map<String, Object> topoConf, AdvancedFSOps
ops, String profileCmd) throws IOException {
+ super(type, conf, supervisorId, port, assignment,
resourceIsolationManager, localState, workerId, topoConf, ops,
+ profileCmd);
+ if (Utils.isOnWindows()) {
+ throw new UnsupportedOperationException("ERROR: Windows
doesn't support running workers as different users yet");
+ }
+ }
+
+ private void signal(long pid, int signal) throws IOException {
+ List<String> commands = Arrays.asList("signal",
String.valueOf(pid), String.valueOf(signal));
+ String user = getWorkerUser();
+ String logPrefix = "kill -"+signal+" " + pid;
+ SupervisorUtils.processLauncherAndWait(_conf, user, commands,
null, logPrefix);
+ }
+
+ @Override
+ protected void kill(long pid) throws IOException {
+ signal(pid, 15);
+ }
+
+ @Override
+ protected void forceKill(long pid) throws IOException {
+ signal(pid, 9);
+ }
+
+ @Override
+ protected boolean runProfilingCommand(List<String> command,
Map<String, String> env, String logPrefix, File targetDir) throws IOException,
InterruptedException {
+ String user = this.getWorkerUser();
+ String td = targetDir.getAbsolutePath();
+ LOG.info("Running as user:{} command:{}", user, command);
--- End diff --
Nitpick: Might want to add spaces between the colon and braces
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
