Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1642
I have a few style-related nits, but I've refrained from pointing them out
because the style(s) in the codebase are all over the place, and the style is
inherited in some places. If we want to get nit picky over style, we should
really have a style guide in place. That's a JIRA for another day...
Overall I think it looks great and I am +1 for merging. Thanks @revans2 for
the great work, and everyone else for the thorough review.
In terms of back porting this to other branches, I'm okay with that. While
the impetus behind this work was the Clojure to Java migration, I think the
improvements made here warrant back-porting to earlier version branches. It
also doesn't really affect user-facing APIs, so that's not a concern.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
