GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/1696
STORM-2104: More graceful handling of acked/failed tuples after partiâ¦
â¦tion reassignment in new Kafka spout
See https://issues.apache.org/jira/browse/STORM-2104
In order to test this change I added a factory for KafkaConsumers. Please
let me know if there's a nicer way to mock it.
In addition to fixing the described issue, I changed a few types on
KafkaSpoutConfig. If the user specifies a non-serializable Deserializer in
either setter in KafkaSpoutConfig.Builder, the topology can't start because
Nimbus can't serialize KafkaSpoutConfig.
I borrowed a few classes from https://github.com/apache/storm/pull/1679. I
hope that's okay with you @jfenc91.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srdo/storm STORM-2104
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1696.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1696
----
commit d319b0a68ac6537d6e9561da8e90b693c2b9f990
Author: Stig Rohde Døssing <stigdoess...@gmail.com>
Date: 2016-09-20T11:53:55Z
STORM-2104: More graceful handling of acked/failed tuples after partition
reassignment in new Kafka spout
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
