Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1710#discussion_r80324279
--- Diff:
storm-core/test/jvm/org/apache/storm/PaceMakerStateStorageFactoryTest.java ---
@@ -20,13 +20,22 @@
import org.apache.storm.cluster.PaceMakerStateStorage;
import org.apache.storm.generated.*;
import org.apache.storm.pacemaker.PacemakerClient;
+import org.apache.storm.pacemaker.PacemakerClientPool;
import org.apache.storm.utils.Utils;
import org.junit.Assert;
import org.junit.Test;
-public class PaceMakerStateStorageFactoryTest {
+import java.util.HashMap;
+import java.util.List;
+import java.util.ArrayList;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
- private PacemakerClient clientProxy;
+public class PaceMakerStateStorageFactoryTest {
+ private static Logger LOG =
LoggerFactory.getLogger(PaceMakerStateStorageFactoryTest.class);
--- End diff --
We don't seem to be logging anything in this test. Do we need the Logger?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
