Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/1742#discussion_r88447536 --- Diff: external/sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/datasource/socket/SocketDataSourcesProvider.java --- @@ -0,0 +1,94 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.storm.sql.runtime.datasource.socket; + +import com.google.common.collect.Lists; +import org.apache.storm.sql.runtime.DataSource; +import org.apache.storm.sql.runtime.DataSourcesProvider; +import org.apache.storm.sql.runtime.FieldInfo; +import org.apache.storm.sql.runtime.FieldNameExtractor; +import org.apache.storm.sql.runtime.ISqlTridentDataSource; +import org.apache.storm.sql.runtime.SimpleSqlTridentConsumer; +import org.apache.storm.sql.runtime.datasource.socket.trident.SocketState; +import org.apache.storm.sql.runtime.datasource.socket.trident.SocketStateUpdater; +import org.apache.storm.sql.runtime.datasource.socket.trident.TridentSocketSpout; +import org.apache.storm.sql.runtime.serde.json.JsonSerializer; +import org.apache.storm.trident.spout.ITridentDataSource; +import org.apache.storm.trident.state.StateFactory; +import org.apache.storm.trident.state.StateUpdater; + +import java.net.URI; +import java.util.List; + +/** + * Create a Socket data source based on the URI and properties. The URI has the format of + * socket://[host]:[port]. Both of host and port are mandatory. + * + * Note that it connects to given host and port, and receive the message if it's used for input source, + * and send the message if it's used for output data source. + */ +public class SocketDataSourcesProvider implements DataSourcesProvider { + @Override + public String scheme() { + return "socket"; + } + + private static class SocketTridentDataSource implements ISqlTridentDataSource { + + private final List<String> fieldNames; + private final String host; + private final int port; + + SocketTridentDataSource(List<FieldInfo> fields, String host, int port) { + this.fieldNames = Lists.transform(fields, new FieldNameExtractor()); --- End diff -- Maybe we need a upmerge. use `FieldInfoUtils.getFieldNames` as the replacement.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---