Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1826#discussion_r92546386
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -77,7 +77,7 @@
private KafkaSpoutStreams kafkaSpoutStreams; //
Object that wraps all the logic to declare output fields and emit tuples
private transient KafkaSpoutTuplesBuilder<K, V> tuplesBuilder; //
Object that contains the logic to build tuples for each ConsumerRecord
- private transient Map<TopicPartition, OffsetEntry> acked; //
Tuples that were successfully acked. These tuples will be committed
periodically when the commit timer expires, after consumer rebalance, or on
close/deactivate
+ transient Map<TopicPartition, OffsetEntry> acked; // Tuples
that were successfully acked. These tuples will be committed periodically when
the commit timer expires, after consumer rebalance, or on close/deactivate
--- End diff --
I believe this is for testing purposes, right? There are ways for testing
frameworks to access private fields, if really necessary. I am in favor of not
break encapsulation and expose internal state for the purposes of testing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
