Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1862#discussion_r95174977
  
    --- Diff: storm-core/src/jvm/org/apache/storm/utils/DisruptorQueue.java ---
    @@ -63,6 +63,18 @@
         private static final String PREFIX = "disruptor-";
         private static final FlusherPool FLUSHER = new FlusherPool();
     
    +    private static int getNumFlusherPoolThreads() {
    +        int numThreads = 100;
    +        try {
    +            String threads = 
System.getProperty("num_flusher_pool_threads", "100");
    --- End diff --
    
    The issue with using a Config for this is that readStormConfig inside the 
worker would read the system config, not the topology config, and would not let 
us override it on a per topology bases.  I will add in a config for the system 
default, but in the documents there indicate the system property that can be 
set to override it for a topology.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to