Thanks for thorough review. It's a great example of what a good review looks like.
Comments in line below. -Taylor > On Jan 31, 2017, at 11:33 PM, Jungtaek Lim <[email protected]> wrote: > > +1 (binding) > >> source > > - verify file (signature, MD5, SHA) > -- source, tar.gz : OK > -- source, zip : OK > > - extract file > -- source, tar.gz : OK > -- source, zip : OK > > - diff-ing extracted files between tar.gz and zip : OK > > - build source with JDK 7 > -- source, tar.gz : OK > > - build source dist > -- source, tar.gz : OK > > - build binary dist > -- source, tar.gz : OK > >> binary > > - verify file (signature, MD5, SHA) > -- binary, tar.gz : OK > -- binary, zip : OK > > - extract file > -- source, tar.gz : OK > -- source, zip : OK > > - diff-ing extracted files between tar.gz and zip : OK > > - launch daemons : OK > - run RollingTopWords (local) : OK > - run RollingTopWords (remote) : OK > - activate / deactivate / rebalance / kill : OK > - logviewer (worker dir, daemon dir) : OK > - change log level : OK > - thread dump, heap dump, restart worker : OK > - log search : OK > - run WordCountTopology (multilang, remote) : OK > - run StatefulTopology (local) : OK > - run StatefulTopology (remote) : OK > - run StatefulWindowingTopology (remote) : OK > > Found two bugs here which are not blocker: > > 1. visualization: it doesn't show graph correctly while worker is being > initializing, and below error message is printed on console, which I think > is long-lasting bug. > I think this has been around for a while. I agree that it's not a blocker. > 2. running topology with local cluster doesn't terminate after cluster > shutdown: Took stack trace, and found some non-daemon threads are live: > Async Localizer, Localizer Cache Cleanup x 2. Local mode or a single node cluster? I saw this when testing the worker shutdown hook bug in local mode. I don't think this is a blocker, but we should definitely follow up with a JIRA. This could affect users who rely on local mode for integration tests. > > I'll file two issues afterwards. > > Thanks, > Jungtaek Lim (HeartSaVioR) > > 2017년 2월 1일 (수) 오전 5:55, P. Taylor Goetz <[email protected]>님이 작성: > >> This is a call to vote on releasing Apache Storm 1.0.3 (rc1) >> >> Full list of changes in this release: >> >> >> https://git-wip-us.apache.org/repos/asf?p=storm.git;a=tree;h=6cb735d18ec11eccd3e80bab8f879c989a9b3967;hb=a81ec2580fce1f2ee6349a9028dcb75763798bec >> >> The tag/commit to be voted upon is v1.0.3: >> >> >> https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=CHANGELOG.md;h=b8adddc6aa20107288e59cba6a2976c0951742fb;hb=a81ec2580fce1f2ee6349a9028dcb75763798bec >> >> The source archive being voted upon can be found here: >> >> >> https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.0.3-rc1/apache-storm-1.0.3-src.tar.gz >> >> Other release files, signatures and digests can be found here: >> >> https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.0.3-rc1/ >> >> The release artifacts are signed with the following key: >> >> >> https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=KEYS;hb=22b832708295fa2c15c4f3c70ac0d2bc6fded4bd >> >> The Nexus staging repository for this release is: >> >> https://repository.apache.org/content/repositories/orgapachestorm-1043 >> >> Please vote on releasing this package as Apache Storm 1.0.3. >> >> When voting, please list the actions taken to verify the release. >> >> This vote will be open for at least 72 hours. >> >> [ ] +1 Release this package as Apache Storm 1.0.3 >> [ ] 0 No opinion >> [ ] -1 Do not release this package because... >> >> Thanks to everyone who contributed to this release. >> >> -Taylor
