+1 to cancel this RC, port back issues Jungtaek listed, and open RC2 ASAP. - Xin
2017-02-04 6:47 GMT+08:00 Jungtaek Lim <kabh...@gmail.com>: > I'm OK to cancel RC1, and port back those issues, and open RC2 ASAP. > > I think below things are needed to be ported back to 1.0.x branch: > > STORM-2197 <https://issues.apache.org/jira/browse/STORM-2197> > STORM-2321 <https://issues.apache.org/jira/browse/STORM-2321> > STORM-2324 <https://issues.apache.org/jira/browse/STORM-2324> > STORM-2335 <https://issues.apache.org/jira/browse/STORM-2335> > STORM-2336 <https://issues.apache.org/jira/browse/STORM-2336> > > Moreover including STORM-2337 > <https://issues.apache.org/jira/browse/STORM-2337> and STORM-2338 > <https://issues.apache.org/jira/browse/STORM-2338> seems fine given that > they're small fixes. > > Regarding worker-launcher binary, my guess is that release manager needs to > install target OSs and builds them for every OSs. Unless we have build > machines to build them conveniently, this will require hard work for > releasing. IMHO, if we documented guiding how to build worker-launcher, I > think we're OK. > > Thanks, > Jungtaek Lim (HeartSaVioR) > > 2017년 2월 4일 (토) 오전 6:06, P. Taylor Goetz <ptgo...@gmail.com>님이 작성: > > > Hi Tibor, > > > > Anyone can vote on a release, in fact it’s encouraged. Though only > > committer votes are considered binding. > > > > Though the vote is scheduled to close today, I will keep it open over the > > weekend so others can chime in as to whether we want to include > STORM-2197 > > in the 1.0.3 release. > > > > Jungtaek also identified STORM-2335 and STORM-2336 as defects in this rc. > > > > I’m perfectly fine with canceling this rc to address those issues, if > > that’s the consensus. What are other’s thoughts? > > > > As far as the worker-launcher binaries go, that’s kind of a difficult > > task. We would need to build them for every platform we intend to target. > > It would complicate the release process, but I’m open to suggestions if > we > > want to go in that direction. > > > > -Taylor > > > > > On Feb 3, 2017, at 3:41 PM, Tibor Kiss <tk...@hortonworks.com> wrote: > > > > > > Hello, > > > > > > I'm not sure I can vote but I have two issues to raise: > > > 1) a connection leak fix is missing from this release: > > > STORM-2197 was only merged to 1.x-branch. > > > This issue (along with STORM-2042) has been causing problems to our > > customers recently. > > > 2) Just discovered that worker-launcher is not included in apache > binary > > distributions. > > > Raised a ticket (without resolution): STORM-2341 > > > > > > I hope it is not too late to address those issues. > > > > > > Thanks, > > > Tibor > > > > > > > > > On 1/31/17, 9:55 PM, "P. Taylor Goetz" <ptgo...@gmail.com> wrote: > > > > > > This is a call to vote on releasing Apache Storm 1.0.3 (rc1) > > > > > > Full list of changes in this release: > > > > > > > > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=tree;h= > 6cb735d18ec11eccd3e80bab8f879c989a9b3967;hb=a81ec2580fce1f2ee6349a9028dcb7 > 5763798bec > > > > > > The tag/commit to be voted upon is v1.0.3: > > > > > > > > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_ > plain;f=CHANGELOG.md;h=b8adddc6aa20107288e59cba6a2976c0951742fb;hb= > a81ec2580fce1f2ee6349a9028dcb75763798bec > > > > > > The source archive being voted upon can be found here: > > > > > > > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-1. > 0.3-rc1/apache-storm-1.0.3-src.tar.gz > > > > > > Other release files, signatures and digests can be found here: > > > > > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-1. > 0.3-rc1/ > > > > > > The release artifacts are signed with the following key: > > > > > > > > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_ > plain;f=KEYS;hb=22b832708295fa2c15c4f3c70ac0d2bc6fded4bd > > > > > > The Nexus staging repository for this release is: > > > > > > > > https://repository.apache.org/content/repositories/orgapachestorm-1043 > > > > > > Please vote on releasing this package as Apache Storm 1.0.3. > > > > > > When voting, please list the actions taken to verify the release. > > > > > > This vote will be open for at least 72 hours. > > > > > > [ ] +1 Release this package as Apache Storm 1.0.3 > > > [ ] 0 No opinion > > > [ ] -1 Do not release this package because... > > > > > > Thanks to everyone who contributed to this release. > > > > > > -Taylor > > > > > > > > > > >