Github user srdo commented on the issue:
https://github.com/apache/storm/pull/1930
Hi. You should raise an issue at
https://issues.apache.org/jira/browse/STORM so the fix can be tracked. Then
rename the PR to mention the jira issue number (take a look at the other open
PRs to see what it usually looks like). You should also open a PR for master
first, then the fix can be cherry picked back to 1.x-branch once it goes in.
About the contents of this PR: I think getting rid of kafka-unit is a good
idea. It uses deprecated Kafka APIs. That said, I'd prefer if we could replace
it with something similar since we're likely going to be using embedded Kafka
for other tests in the future, and copy-pasting code to other test classes
would get tedious. Would you be up for wrapping the setup/teardown code for the
Kafka broker in a junit TestRule
(https://github.com/junit-team/junit4/wiki/Rules#custom-rules)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
