GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1950
STORM-2369 [storm-redis] Use binary type for State management (1.x)
* introduce new command interface and relevant containers
* new command interface will contain both binary and string commands in
near future
* change RedisKeyValue to use byte[] for State key and value management
instead of String
* get rid of Base64 encode/decode on RedisEncoder, and also
SafeEncoder.encode() in Jedis internal
* implement some utils for handling Map with byte[]: since byte[] is bad
for key type of Map
NOTE: Currently I can't run or debug tests on IntelliJ for master branch
(so worked on 1.x-branch). I also heard many folks are struggling, so might be
better to address it soon.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-2369-1.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1950.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1950
----
commit 1c73ceeca7d78fde44cead5d7b9b5b8d0ad9e7e4
Author: Jungtaek Lim <[email protected]>
Date: 2017-02-21T06:35:58Z
STORM-2369 [storm-redis] Use binary type for State management
* introduce new command interface and relevant containers
* new command interface will contain both binary and string commands in
near future
* change RedisKeyValue to use byte[] for State key and value management
instead of String
* get rid of Base64 encode/decode on RedisEncoder, and also
SafeEncoder.encode() in Jedis internal
* implement some utils for handling Map with byte[]: since byte[] is bad
for key type of Map
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
