Github user tibkiss commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1962#discussion_r102898864
  
    --- Diff: 
external/storm-jdbc/src/main/java/org/apache/storm/jdbc/common/HikariCPConnectionProvider.java
 ---
    @@ -40,6 +44,10 @@ public synchronized void prepare() {
                 Properties properties = new Properties();
                 properties.putAll(configMap);
                 HikariConfig config = new HikariConfig(properties);
    +            if(properties.containsKey("dataSource.url"))
    +                LOG.info("DataSource Url: " + 
properties.getProperty("dataSource.url"));
    +            else if (config.getJdbcUrl() != null)
    +                LOG.info("JDBC Url: " + config.getJdbcUrl());
    --- End diff --
    
    Shouldn't this printout be independent of the presence of dataSource.url?
    i.e. just an {{if}} instead of {{else if}} 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to