Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1924#discussion_r104603040
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -270,17 +272,36 @@ public void setWaitingToEmit(ConsumerRecords<K,V>
consumerRecords) {
// ======== poll =========
private ConsumerRecords<K, V> pollKafkaBroker() {
- doSeekRetriableTopicPartitions();
+ Set<TopicPartition> retriableTopicPartitions =
doSeekRetriableTopicPartitions();
+ Set<TopicPartition> pausedTopicPartitions =
pauseNonRetriableTopicPartitionsIfAtUncommittedOffsetsLimit(retriableTopicPartitions);
if (refreshSubscriptionTimer.isExpiredResetOnTrue()) {
kafkaSpoutConfig.getSubscription().refreshAssignment();
}
final ConsumerRecords<K, V> consumerRecords =
kafkaConsumer.poll(kafkaSpoutConfig.getPollTimeoutMs());
--- End diff --
Minor: I'd rather apply defensive programming here (to guarantee calling
`resume` at any chance) like below:
```
try {
final ConsumerRecords<K, V> consumerRecords =
kafkaConsumer.poll(kafkaSpoutConfig.getPollTimeoutMs());
final int numPolledRecords = consumerRecords.count();
LOG.debug("Polled [{}] records from Kafka. [{}] uncommitted offsets
across all topic partitions", numPolledRecords, numUncommittedOffsets);
return consumerRecords;
} finally {
if (!pausedTopicPartitions.isEmpty()) {
//Ensure that we resume all partitions in case some were paused
when processing retries
kafkaConsumer.resume(kafkaConsumer.assignment());
}
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
