Github user ikashperskyi commented on a diff in the pull request:
https://github.com/apache/storm/pull/1989#discussion_r104642490
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -356,13 +358,14 @@ public static void sleep(long millis) {
try {
Time.sleep(millis);
} catch(InterruptedException e) {
+ currentThread().interrupt();
--- End diff --
Here's a suboptimal example of a loop that will never exit as intended
`while(!currentThread.isInterrupted()) {
execute();
}
...
void execute() {
try {
... // RE may be thrown here
Utils.sleep(1000);
... // and here
} catch (RuntimeException e)
log.error(e);
}
}`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
