Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1980#discussion_r105030392
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -164,15 +164,15 @@ public Builder(Map<String, Object> kafkaProps,
KafkaSpoutStreams kafkaSpoutStrea
/**
* Specifying this key deserializer overrides the property
key.deserializer
*/
- public Builder<K,V> setKeyDeserializer(Deserializer<K>
keyDeserializer) {
+ public Builder<K,V> setKeyDeserializer(SerializableDeserializer<K>
keyDeserializer) {
--- End diff --
I'm not 100% sure it keeps binary compatibility. `Serializable ` doesn't
have methods so it might work, but just not sure.
Once who makes me clear that this is also safe for binary compatibility,
I'll give +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
