Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1924#discussion_r106531182
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -268,12 +268,12 @@ private Builder(Builder<?, ?> builder,
SerializableDeserializer<K> keyDes, Class
/**
* The maximum number of records a poll will return.
- * Will only work with Kafka 0.10.0 and above.
+ * This is limited by maxUncommittedOffsets, since it doesn't make
sense to allow larger polls than the spout is allowed to emit.
+ * Please note that when there are retriable tuples on a
partition, maxPollRecords is an upper bound for how far the spout will read
past the last committed offset on that partition.
+ * It is recommended that users set maxUncommittedOffsets and
maxPollRecords to be equal.
--- End diff --
@srdo this should not be the case. From our discussion,
maxUncommittedOffsets should be much larger than maxPollRecords
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
