Github user satishd commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2019#discussion_r106795805
  
    --- Diff: storm-core/src/jvm/org/apache/storm/bolt/JoinBolt.java ---
    @@ -191,9 +191,9 @@ public void execute(TupleWindow inputWindow) {
             for (ResultRecord resultRecord : joinResult.getRecords()) {
                 ArrayList<Object> outputTuple = resultRecord.getOutputFields();
                 if ( outputStreamName==null )
    -                collector.emit( outputTuple );
    +                collector.emit( resultRecord.tupleList, outputTuple );
    --- End diff --
    
    It may be good to add a comment here, saying that anchoring with only 
matched input tuples as .
    `WindowedOutputCollector` anchors with all the incoming tuples.
    
    For others to understand the issue, collector used here is 
[`WindowedOutputCollector`](https://github.com/apache/storm/blob/master/storm-core/src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java#L31)
 and it emits  output tuple by anchoring with all the input tuples with in that 
window.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to