Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1924#discussion_r107542392
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutRetryExponentialBackoff.java
---
@@ -60,17 +61,19 @@ public int compare(RetrySchedule entry1, RetrySchedule
entry2) {
if(result == 0) {
//TreeSet uses compareTo instead of equals() for the Set
contract
//Ensure that we can save two retry schedules with the
same timestamp
- result = entry1.hashCode() - entry2.hashCode();
+ result = entry1.instanceNumber - entry2.instanceNumber;
--- End diff --
Will revert to using hashCode(). I'd like to at least keep that check,
since it would be annoying in tests using simulated time if we had to add 1
nanosecond between every call to spout.fail().
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
