GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2073
STORM-2478: Fix BlobStoreTest.testDeleteAfterFailedCreate on Windows
See https://issues.apache.org/jira/browse/STORM-2478
I couldn't think of a way to fix this test without exposing the getKeyDir
method. When the AtomicOutputStream in BlobStoreTest L181 is closed, the
temporary file is renamed to `data`, which is deleted explicitly when the blob
store is deleted. This makes the test meaningless since it's checking that the
blob store directory can be deleted when there are temporary files in it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srdo/storm STORM-2478
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2073.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2073
----
commit 207421c5198017672ab598e9c41bf8724389f0b7
Author: Stig Rohde Døssing <[email protected]>
Date: 2017-04-16T16:02:07Z
STORM-2478: Fix BlobStoreTest.testDeleteAfterFailedCreate on Windows
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
