Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2075#discussion_r111994814
--- Diff:
storm-client/src/jvm/org/apache/storm/security/auth/ThriftServer.java ---
@@ -45,34 +48,50 @@ public ThriftServer(Map storm_conf, TProcessor
processor, ThriftConnectionType t
} catch (Exception x) {
LOG.error(x.getMessage(), x);
}
+ try {
+ //locate our thrift transport plugin
+ ITransportPlugin transportPlugin =
AuthUtils.GetTransportPlugin(_type, _storm_conf, _login_conf);
+ //server
+ _server = transportPlugin.getServer(_processor);
+ _port = transportPlugin.getPort();
+ } catch (IOException | TTransportException ex) {
+ handleServerException(ex);
+ }
+
}
public void stop() {
- if (_server != null)
- _server.stop();
+ _server.stop();
--- End diff --
I checked, AuthUtils.GetTransportPlugin can't return null, and neither
included implementation of ITransportPlugin can return null :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
