- Personally not a big fan of _ for members either from the readability standpoint. Also much of the existing code doesn’t follow this. - Personally I find it is easier to write/read one-liner if/else without the curlys. Always wondered about the rationale behind that.
Would suggest any such a coding convention be very minimalist as a conding convention’s usefulness is inversely proportional to its length ( -roshan Would be good to keep any such coding convention as minimalistic and On 4/25/17, 3:50 PM, "Jungtaek Lim" <[email protected]> wrote: I would like to review the style guide of other projects, like HBase, and so. Btw, IMHO, I don't like using underscore as prefix for fields. We're using Java and the expression "class member variable" is from C++, and also underscore style came from C++. We need to avoid mixing other languages' style as well. Thanks, Jungtaek Lim (HeartSaVioR) 2017년 4월 26일 (수) 오전 7:10, Kyle Nusbaum <[email protected]>님이 작성: > Now that most of our code is in Java, I think it might be time to revisit > the issue of having some official and enforced code style. > I don't have very strong feelings about most of it, but here is what I was > thinking as a start, since I've seen this style quite a bit, and I've found > it makes code pretty easy to read: > 1. Indentation is 4 spaces per level (no tabs) > 2. All class member variables begin with underscore3. No wildcard > imports4. if / else / for / etc. always get curly braces. > There are obviously tons of other things, and we can get as picky as we > want, but I think enforcing at least these rules would go a long way to > making the code more consistent. > > Thoughts? > > Thanks, > -- Kyle
