Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/2090#discussion_r113369572
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/TimeTriggerPolicy.java ---
@@ -109,13 +112,22 @@ private Runnable newTriggerTask() {
return new Runnable() {
@Override
public void run() {
+ // compute the current trigger timestamp based on
prevTriggerTimestamp,
+ // since the calculation based on System.currentTimeMillis
might have a slight drift
+ long now = System.currentTimeMillis();
+ long triggerTs = prevTriggerTimestamp == 0 ? now :
prevTriggerTimestamp + duration;
+ prevTriggerTimestamp = triggerTs;
+ if (Math.abs(triggerTs - now) > 1000) {
--- End diff --
OK, Throwing warning incase of large drifts looks fine for now.
Multiple concurrent executes will not happen as there is only one thread
which executes the bolt and the subsequent bolt executions wait till the
current execution is done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
