Github user dossett commented on the issue:

    https://github.com/apache/storm/pull/1044
  
    Hi @ryanpersaud -- that is a very good observation, it would seem that 
doesn't happen.  I admit to being biased against rotation actions and would 
never use them in production, which is probably why I never noticed it.  But 
that's not a good enough reason for a bug like that!
    
    Since changing jobs last year I don't have the opportunity to actively work 
on Storm anymore, but if you have thoughts on a fix I would certainly give a 
code review my full attention. A failing unit test to confirm the behavior 
(using a Mockito spy to confirm that close isn't called) would be a very 
helpful start.
    
    Thank you for pointing this out!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to