Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2104#discussion_r115305431
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/OffsetManager.java
---
@@ -49,10 +51,14 @@ public OffsetManager(TopicPartition tp, long
initialFetchOffset) {
LOG.debug("Instantiated {}", this);
}
- public void add(KafkaSpoutMessageId msgId) { // O(Log N)
+ public void ack(KafkaSpoutMessageId msgId) { // O(Log N)
--- End diff --
why rename this method? There is no acking happening in here. There is a
message being added to the internal state of this object, which is reflected by
the name **add**. The name **ack** is misleading.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
