Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2072#discussion_r117247297
--- Diff: .travis.yml ---
@@ -27,6 +27,7 @@ before_install:
- rvm use 2.1.5 --install
- nvm install 0.12.2
- nvm use 0.12.2
+ - ./transform.sh
--- End diff --
Sorry Maybe I didn't make myself clear in the initial comments. Because
this is touching a lot of different places in the code I thought it would be
best to have the transformations be done by a script, that way if other stuff
is merged in, we don't have to worry as much about merge conflicts.
If I get the needed +1s on the change I will run the script, remove it and
any mention of it in the code and check in the result before merging it to
master.
I added this line so that travis could test the fully transformed code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
