I feel , just for check-style issue fix, we shouldn’t change public method names in 1.x
Thanks Vinod On 5/21/17, 4:10 PM, "srdo" <[email protected]> wrote: Github user srdo commented on the issue: https://github.com/apache/storm/pull/2117 @erikdw @revans2 @vinodkc You guys might have an opinion on this, since I've seen you discuss checkstyle on other PRs. How do you feel about the method renames in KafkaSpoutConfig in f9e331ddb3e8c1d917a2c9e27c2afbce7ba3dad0? I think we shouldn't make this kind of breaking change in 1.x, but 2.0 isn't released yet so it's probably OK here? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [email protected] or file a JIRA ticket with INFRA. ---
