As this is for a change going into 2.x I totally agree lets just change the API. If we really want to do a good job we can also have a pull request in the 1.x version that adds in the new API and deprecates the old one, so users are not caught off guard as much.
- Bobby On Sunday, May 21, 2017, 6:11:19 AM CDT, Jungtaek Lim <[email protected]> wrote: I prefer to not have too much exceptions from chosen style guide. So I'm OK to change the method to setSslKeystore, but just would like to hear others voices because we're breaking backward compatibility once again (we did it at 1.1.0) just because of respecting code style. - Jungtaek Lim (HeartSaVioR) 2017년 5월 21일 (일) 오후 8:07, Stig Rohde Døssing <[email protected]>님이 작성: > Hi, > > As part of fixing the checkstyle violations on storm-kafka-client, we'd > need to rename some methods on KafkaSpoutConfig. See > https://github.com/apache/storm/pull/2117. Does anyone have an opinion on > when/if it is acceptable to break the API for this reason? > > I'd also like opinions on whether method names like setSslKeystore are > better than setSSLKeystore? The current checkstyle rules prohibit adjacent > capital letters in non-final names due to this bit of the checkstyle > config. > > <module name="AbbreviationAsWordInName"> > <property name="ignoreFinal" value="false"/> > <property name="allowedAbbreviationLength" value="1"/> > </module> >
