GitHub user carl34 opened a pull request:

    https://github.com/apache/storm/pull/2132

    Add the option to set client.id to storm-kafka

    Add the ability to set the Kafka client.id property to storm-kafka and 
storm-kafka-client (https://issues.apache.org/jira/browse/STORM-2524).
    
    storm-kafka example:
    ```
        SpoutConfig spoutConfig = new SpoutConfig(
                brokers,
                topicConfs.topic,
    +           "client_id-" + confs.consumerGroupId + "-" + topicConfs.topic,
                "/consumers",
                confs.consumerGroupId + "-" + topicConfs.topic
        );
    ```
    
    storm-kafka-client example:
    ```
        KafkaSpoutConfig<String,String> kafkaSpoutConfig = 
KafkaSpoutConfig.builder(KAFKA_LOCAL_BROKER, TOPIC)
                .setGroupId(confs.consumerGroupId + "-" + topicConfs.topic)
    +           .setClientId("client_id-" + confs.consumerGroupId + "-" + 
topicConfs.topic)
                .build();
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/carl34/storm master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2132.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2132
    
----
commit ca50f699a4f7b50ef2f463ed076297abeabd321a
Author: Carl Haferd <[email protected]>
Date:   2017-05-17T20:04:53Z

    Add the option to set client.id to storm-kafka

commit b26ff87e6c5dc562502a21335e96876162ee77be
Author: Robert Evans <[email protected]>
Date:   2017-05-22T17:08:25Z

    Add the option to set client.id to storm-kafka, STORM-2524

commit 1a895950aa2604d76cd00eecf8973913f92239c4
Author: carl34 <[email protected]>
Date:   2017-05-22T22:04:32Z

    Merge pull request #4 from carl34/kafka_client_id
    
    Add the option to set client.id to storm-kafka, STORM-2524

commit 275d20d07930e6b5901fb082dd0b678abd53904b
Author: Carl Haferd <[email protected]>
Date:   2017-05-22T22:06:58Z

    Merge branch 'master' of https://github.com/carl34/storm

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to