GitHub user adityasharad opened a pull request:
https://github.com/apache/storm/pull/2149
STORM-2503: Fix lgtm.com alerts on equality and comparison operations.
This PR is a port of https://github.com/apache/storm/pull/2100 and
https://github.com/apache/storm/pull/2143 to `1.x-branch`, as suggested by
@HeartSaVioR.
It fixes several alerts involving comparison operations found at
https://lgtm.com/projects/g/apache/storm/alerts.
It also includes a fix to the test for `DefaultResourceAwareStrategy`,
provided by @revans2.
Differences from the original PRs:
- there appears to be no `SubSystem` class in this branch, so the addition
of a `hashCode` method to it is not ported here
- `SchedulerAssignmentImpl` does not have an `equals` method in this
branch, so the addition of a `hashCode` method is not ported here
- the `DefaultResourceAwareStrategy::sortNeighbors` comparator logic that
was incorrectly changed in #2100 and restored in #2143 is not altered here
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/adityasharad/storm fix/1.x/lgtm-alerts
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2149.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2149
----
commit 7d7dfbb3262c34a9fd1384c7d11128aa3501142d
Author: Aditya Sharad <[email protected]>
Date: 2017-06-05T02:33:16Z
STORM-2503: Fix lgtm.com alerts on equality and comparison operations.
Fixes several alerts involving comparison operations
found at https://lgtm.com/projects/g/apache/storm/alerts.
commit 433c95b80bc92ae111ae91bbea4da9ffd393937e
Author: Robert (Bobby) Evans <[email protected]>
Date: 2017-05-15T20:55:49Z
Fixed test failure
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
