[GitHub] storm pull request #2148: Let Topology query if blobs have changed

[revans2]

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2148#discussion_r120129559
  
    --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java 
---
    @@ -246,7 +248,19 @@ public void start() throws Exception {
                                 }
                             }
                         });
    -              
    +
    +                workerState.checkForUpdatedBlobsTimer.scheduleRecurring(0,
    +                        (Integer) 
conf.getOrDefault(Config.WORKER_BLOB_UPDATE_POLL_INTERVAL_SECS, 10), new 
Runnable() {
    +                            @Override public void run() {
    +                                try {
    +                                    LOG.info("Checking if blobs have 
updated");
    +                                    updateBlobUpdates();
    +                                } catch (IOException e) {
    +                                    e.printStackTrace();
    --- End diff --
    
    Can we log this instead of printing it to stderr?  Also it might be nice to 
have a comment explaining why you are ignoring the exception.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---