Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2113#discussion_r120432365
--- Diff:
storm-client/src/jvm/org/apache/storm/scheduler/SchedulerAssignment.java ---
@@ -21,41 +21,51 @@
import java.util.Map;
import java.util.Set;
+import org.apache.storm.generated.Assignment;
+import org.apache.storm.generated.WorkerResources;
+
public interface SchedulerAssignment {
/**
* Does this slot occupied by this assignment?
* @param slot
- * @return
+ * @return true the slot is occupied else false
--- End diff --
Nitpick: missing "if" between true and the. Also the comment two lines up
is phrased a little weirdly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
