Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2113#discussion_r120687251
--- Diff:
storm-client/src/jvm/org/apache/storm/scheduler/SchedulerAssignment.java ---
@@ -21,41 +21,52 @@
import java.util.Map;
import java.util.Set;
+import org.apache.storm.generated.Assignment;
+import org.apache.storm.generated.WorkerResources;
+
public interface SchedulerAssignment {
/**
* Does this slot occupied by this assignment?
* @param slot
- * @return
+ * @return true if the slot is occupied else false
*/
public boolean isSlotOccupied(WorkerSlot slot);
/**
- * is the executor assigned?
+ * Is the executor assigned?
*
* @param executor
- * @return
+ * @return true if it is assigned else false
*/
public boolean isExecutorAssigned(ExecutorDetails executor);
/**
- * get the topology-id this assignment is for.
- * @return
+ * Return the ID of the topolgoy.
--- End diff --
I even typo my fixes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
