Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2177#discussion_r123886555
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/NamedSubscription.java
---
@@ -56,6 +57,6 @@ public NamedSubscription(String ... topics) {
@Override
public String getTopicsString() {
- return String.valueOf(topics);
+ return StringUtils.join(topics, ",");
--- End diff --
I would like to suggest that you use instead Guava's
`Joiner.on(",").join(topics);` which will avoid adding a new dependency
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---