Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2155
@srdo thanks for addressing the code comments. It LGTM, but I forgot to
publish the following comment - sorry for the extra overhead. Do you want to
address it in this patch as well ?
Most of the defaults in
[here](https://github.com/srdo/storm/blob/73adaa983cc421c7974e95011030c54f75e7698a/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java#L38-#L51)
are also in
[here](https://github.com/srdo/storm/blob/73adaa983cc421c7974e95011030c54f75e7698a/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java#L135-#L140).
I think it would be better to have de defaults only in one place, ideally in
the top level class. However, if it makes the code simpler to leave the
defaults only in the Builder class, so be it. Neertheless, we should avoid
having them in both places.
I also would like to ask if you can squash all the commits once we are done
addressing everything, such that we can keep the git log clean. Thanks a lot.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
