Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2181#discussion_r124906681
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/OffsetManager.java
---
@@ -118,6 +118,8 @@ public OffsetAndMetadata findNextCommitOffset() {
OffsetAndMetadata nextCommitOffsetAndMetadata = null;
if (nextCommitMsg != null) {
+ //The committed offset should be the next message
+ nextCommitOffset = nextCommitOffset + 1;
--- End diff --
I would prefer that we fix the offsets in the code block above (L76-117)
instead of adjusting the offset here. That way the log messages won't be
printing the wrong offset.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
