Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2200#discussion_r126518695
  
    --- Diff: docs/Metrics.md ---
    @@ -44,7 +45,7 @@ topology.metrics.consumer.register:
         argument: "http://example.com:8080/metrics/my-topology/";
     ```
     
    -Storm appends MetricsConsumerBolt to your topology per each registered 
metrics consumer internally, and each MetricsConsumerBolt subscribes to receive 
metrics from all tasks. The parallelism for that Bolt is set to 
`parallelism.hint` and `component id` for that Bolt is set to 
`__metrics_<metrics consumer class name>`. If you register same class name more 
than once, postfix `#<sequence number>` is appended to component id.
    +Storm appends MetricsConsumerBolt to your topology per each registered 
metrics consumer internally, and each MetricsConsumerBolt subscribes to receive 
metrics from all tasks. The parallelism for that Bolt is set to 
`parallelism.hint` and `component id` for that Bolt is set to 
`__metrics_<metrics consumer class name>`. If you register the same class name 
more than once, postfix `#<sequence number>` is appended to component id.
    --- End diff --
    
    Should this say "Storm appends one MetricsConsumerBolt [...] per registered 
metrics consumer"?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to