Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2200#discussion_r126551578
  
    --- Diff: docs/Metrics.md ---
    @@ -125,3 +126,193 @@ The [builtin 
metrics]({{page.git-blob-base}}/storm-client/src/jvm/org/apache/sto
     
     
[BuiltinMetricsUtil.java]({{page.git-blob-base}}/storm-client/src/jvm/org/apache/storm/daemon/metrics/BuiltinMetricsUtil.java)
 sets up data structures for the built-in metrics, and facade methods that the 
other framework components can use to update them. The metrics themselves are 
calculated in the calling code -- see for example 
[`ackSpoutMsg`]({{page.git-blob-base}}/storm-client/src/jvm/org/apache/storm/executor/Executor.java).
     
    +#### Reporting Rate
    +
    +The rate at which built in metrics are reported is configurable through 
the `topology.builtin.metrics.bucket.size.secs` metric.  If you set this too 
low it can overload the consumers
    +and some metrics consumers expect metrics to show up at a fixed rate or 
the numbers could be off, so please use caution when modifying this.
    --- End diff --
    
    Sure, but wouldn't that just be a performance issue? I'm referring to "and 
some metrics consumers expect metrics to show up at a fixed rate or the numbers 
could be off", which seems to say that some consumers will report the wrong 
results if the bucket size is changed(?)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to