GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/2204
(WIP) STORM-1280 port backtype.storm.daemon.logviewer to java
* port logviewer to Java using Dropwizard
* follow implementation of DRPC Server
* add '/api/v1/' to the logviewer API endpoints
* seems like it is not possible (or not easy) to serve both API endpoints
and static resources in same servlet
* reflect the change to the static resources
Please note that logviewer test should be ported to Java since ported
version of Logviewer is placed to storm-webapp module. Below is TODO list:
TODO
* [ ] - port logviewer-test.clj to Java and delete logviewer-test.clj
* [ ] - delete logviewer.clj and rename package to remove 'wip'
I've added J2HTML and jOOL as dependencies for storm-webapp: J2HTML as
replacement for hiccup, and jOOL as Java 8 lambda helper.
Manually tested. Unit test will be covered with porting logviewer-test.clj.
Please let me know deleting logviewer.clj is more convenient to review.
Please review and comment. Thanks in advance!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-1280
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2204.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2204
----
commit 73b84d71f9ac3e9b718dbc8794cfaee2ab1faead
Author: Jungtaek Lim <[email protected]>
Date: 2017-07-11T04:49:56Z
(WIP) STORM-1280 port backtype.storm.daemon.logviewer to java
* port logviewer to Java using Dropwizard
* follow implementation of DRPC Server
* add '/api/v1/' to the logviewer API endpoints
* seems like it is not possible (or not easy) to serve both API endpoints
and static resources in same servlet
* reflect the change to the static resources
* TODO: logviewer test should be ported to Java since ported version of
Logviewer is placed to storm-webapp module
* can't remove logviewer.clj for now, hence adding 'wip' to package to
avoid clash
* ported version of Logviewer is manually tested, not testing with
logviewer-test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
