Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2219#discussion_r127842992
  
    --- Diff: storm-core/src/clj/org/apache/storm/daemon/logviewer.clj ---
    @@ -311,7 +311,7 @@
     
     (defn get-log-user-group-whitelist [fname]
       (let [wl-file (ServerConfigUtils/getLogMetaDataFile fname)
    -        m (clojurify-structure (Utils/readYamlFile wl-file))]
    +        m (clojurify-structure (Utils/readYamlFile (.toString wl-file)))]
    --- End diff --
    
    Maybe better to use `getAbsolutePath` or `getCanonicalPath` to clearly 
represent path. I used `getAbsolutePath` from #2204 but I can change it if 
others claim that `getCanonicalPath` is more preferred.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to