Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r128586571
--- Diff: storm-core/src/jvm/org/apache/storm/utils/DisruptorQueue.java ---
@@ -64,6 +67,7 @@
private static final String PREFIX = "disruptor-";
private static final FlusherPool FLUSHER = new FlusherPool();
+ private static final Timer METRICS_TIMER = new
Timer("disruptor-metrics-timer", true);
--- End diff --
Instead of having a timer that updates all of the metrics for the queue,
why don't we just have the Gauge call into the disruptor queue and calculate
the metrics at that point in time? It would match the previous code a lot more
closely, and would not need the extra thread.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
